Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide basic support for FreeBSD #700

Merged
merged 2 commits into from
Nov 22, 2020
Merged

Provide basic support for FreeBSD #700

merged 2 commits into from
Nov 22, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Nov 21, 2020

Description of proposed changes

This PR provides basic support for FreeBSD.

For FreeBSD, sys.platform returns freebsdX, and the suffix of shared libraries is .so.

As per the feedback in the forum https://forum.generic-mapping-tools.org/t/building-gmt-on-freebsd-12-1-release/967/20. FreeBSD users can import pygmt correctly using this PR.

Fixes #698.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Notes

  • You can write /format in the first line of a comment to lint the code automatically

@weiji14 weiji14 added the feature Brand new feature label Nov 22, 2020
@seisman
Copy link
Member Author

seisman commented Nov 22, 2020

Please see the feedback at https://forum.generic-mapping-tools.org/t/building-gmt-on-freebsd-12-1-release/967/20

@seisman seisman added this to the 0.3.0 milestone Nov 22, 2020
@seisman seisman requested a review from weiji14 November 22, 2020 05:31
@seisman seisman marked this pull request as ready for review November 22, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic support for FreeBSD
2 participants