-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move non-plotting modules to separate files in src directory #832
Conversation
All tests still pass and the API documentation looks good. |
Do we want to make separate folders and init.py files in the src folder to import the functions for mathops/gridops/etc.? There aren't a ton of non-plotting functions that are wrapped, but I figure this would keep the overall number of imports into the main pyGMT script low, especially as our numbers of wrapped modules increase. |
I don't think so. Like what you said in #807, if we make separate folders, we still have to decide "if grd2cpt.py should be under mathops/ or grdops/?" |
da95331
to
7f68fa3
Compare
f061eaf
to
a07ac1a
Compare
Good point! |
a07ac1a
to
50d9564
Compare
50d9564
to
65bb719
Compare
65bb719
to
d81a72f
Compare
I almost finished the moving of non-plotting modules, except a few functions that need more discussion:
|
Ping @GenericMappingTools/python and @GenericMappingTools/python-maintainers for comments on #832 (comment) |
Maybe split it into 2 PRs. Name this Part 1 and merge it first, and then we do the ones below in a Part 2 PR.
Agree. Or should we just finish this PR (#832) and move
I would leave these in modules.py for now since they're both classes. We can review them for v0.4.0.
This is a hard one. There are a few other |
Sounds good. Now this PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…MappingTools#832) * Move blockmedian to src * Move grdtrack to src * Move surface to src * Move makecpt to src * Move grdfilter to src * Move grdcut to src * Move info to src * Move which to src
Description of proposed changes
Part 1 of fixing #807
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version