Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self integrate nitro #1307

Merged
merged 13 commits into from
Aug 22, 2024
Merged

Self integrate nitro #1307

merged 13 commits into from
Aug 22, 2024

Conversation

tudorpip
Copy link
Contributor

Pull Request Template

Type of change

  • πŸ• New feature
  • πŸ› Bug Fix
  • πŸ”₯ Breaking change
  • πŸ§‘β€πŸ’» Improvement
  • πŸ“ Documentation Update

Description

A new feature to be able to detect and deploy NitroJs apps, similar to what we do with NextJs.

Checklist

  • My code follows the contributor guidelines of this project;
  • I have updated the documentation;
  • I have added tests;
  • New and existing unit tests pass locally with my changes;

Copy link
Member

@andreia-oca andreia-oca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I have left a few small comments.
After resolving them, this is good to be merged.

Great work! πŸš€πŸš€

tudorpip and others added 3 commits August 22, 2024 12:40
Co-authored-by: Costin Sin <sin.costinrobert@gmail.com>
Co-authored-by: Costin Sin <sin.costinrobert@gmail.com>
Co-authored-by: Costin Sin <sin.costinrobert@gmail.com>
@tudorpip tudorpip merged commit a0cc933 into dev Aug 22, 2024
5 checks passed
@tudorpip tudorpip deleted the self_integrate_nitro branch August 22, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants