RepositoryView improvements #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in the root wrongly discards items (for a/x and b/x the second one is not shown) or places them in a different part of the tree (for a/x/1 and b/x/2 we get the second one under a/x and there's also a phantom b without children).
We may want to warn users when two names or their prefix parts differ only in case, and coax them into renaming, as that may cause problems with some filesystems when they are saved as files (which is not always the case), but we should show them the truth.
The way we are visiting the items there's no point in going deeper. And get out of the loop when the list ends. We are looping on the total number of items, but not starting at the beginning.
We have a call to ItemUnderAt in a loop in FindItem. That itself loops on the items in each call. With EachItemUnder we make that part linear instead of quadratic.
Just add the rest below the new one.
We already know it's not there.
It saves one search. We can only do it for the "flat" view atm.
Sort items so that we can also just add to the end in the tree view.
|
Hi. |
jackburton79
approved these changes
Jan 29, 2024
|
Fine to me too. I think we could reuse the same algo to improve the search
on the ProjectFolder to speedup the path monitoring management.
Il giorno lun 29 gen 2024 alle 21:42 Stefano Ceccherini <
***@***.***> ha scritto:
… ***@***.**** approved this pull request.
Looks good to me. Also tested working correctly
—
Reply to this email directly, view it on GitHub
<#306 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALC2DVVDQWKF5O7PY5TXGTYRACVHAVCNFSM6AAAAABCOOGEICVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBZG4ZDINBRGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes and performance improvements.
For a typical repo with just a few branches the performance improvements are in fact negative, but we are talking about sub millisecond total time there. In my not very old desktop I need about 50 branches to get a clear positive impact, and we are still in the millisecond area.
On the other hand, we all know of that little project with more than 55 thousand tags. Populating the view without the changes takes my desktop 33 seconds without the outline option. With the outline option... well, after 3 hours it still has only 24250 items, and is inserting them at the speed of 0,75 items per second. After the changes it takes 28 seconds, whatever the setting.