-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: acquire data with wags-tails, overhaul static file handling #290
Conversation
probably a git crime to do all of these at once but they felt relevant |
) | ||
|
||
|
||
async def check_status( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method is long -- could be refactored into separate methods for each resource check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 🚀
docs/source/usage.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than linking to main page for rtd, it might be good to point to the api reference for the source
Co-authored-by: Kori Kuzma <korikuzma@gmail.com>
I think this is sufficient to close #204 for now. If we want to circle back and make it actually lazy -- initialize a fetch on instance creation and then await it when actually calling methods -- we can reopen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet
DataDownload
class.check_status()
method to preview whether data dependencies can be acquired without errors (close Provide resource availability check methods #286). Includes current UTA_DB_URL in logging (close Make default UTA DB URL value programmatically accessible #287)FileNotFoundError
if user-provided file paths don't exist. raiseValueError
if they aren't filesdata
module toresources
importlib.resources
to acquire the transcript mappings file rather than relying on relative file structure (hypothetically more reliable for reasons I don't totally understand)2024-02-20
#270)As far as I can tell, this shouldn't impact anything in production, because the environment variables are the first thing
cst
checks -- these changes basically only affect what happens if those fail or aren't provided.