Fix: use static registry key to check vcredist on x86 Windows installer #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the x86 Windows installers rely on the registry key of the "Apps and Features" entry to check if the x86 version of VCRedist has been installed. However the registry key differs between each version of VCRedist, making the installer attempt to install VCRedist during installation when a newer version of VCRedist has been installed. This PR replaces the registry key with the static one and has been tested locally.
Related GitHub Actions runs with the fix: https://github.com/SpecterShell/geoda/actions/runs/8322035879