Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #186 Save Player Name #256

Merged
merged 3 commits into from
Sep 26, 2021
Merged

Conversation

BilelJegham
Copy link
Member

Closes #186

@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #256 (429be24) into master (8ad4d1c) will increase coverage by 0.32%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   40.37%   40.69%   +0.32%     
==========================================
  Files          43       43              
  Lines        1350     1354       +4     
  Branches      258      262       +4     
==========================================
+ Hits          545      551       +6     
+ Misses        780      778       -2     
  Partials       25       25              
Impacted Files Coverage Δ
src/components/Maps.vue 19.44% <ø> (+0.26%) ⬆️
.../components/dialogroom/card/CardRoomPlayerName.vue 28.57% <ø> (ø)
src/store/homeStore.js 64.54% <ø> (ø)
src/store/settingsStore.js 24.28% <50.00%> (+3.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad4d1c...429be24. Read the comment docs.

@BilelJegham BilelJegham marked this pull request as ready for review September 26, 2021 09:12
@BilelJegham BilelJegham merged commit a879510 into master Sep 26, 2021
@BilelJegham BilelJegham deleted the feature/#186-save_playername branch September 26, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Save PlayerName
1 participant