-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a working GitHub Actions config (for CI builds) #173
Conversation
* and add a manual trigger
* previously one got errors like this: MSBUILD : error MSB1003: Specify a project or solution file. The current working directory does not contain a project or solution file.
* in addition to .NET Core 3.1 * and use the latest version of the 'setup-dotnet' action
Ping! Is this repo dead? Can I help with maintenance? Or do I need to fork? |
Sorry for the delay @janusw and thanks again. Repo is not dead, but our day to day job and life leaves small space at some moments ! |
Related discussion in #167 (comment)_ |
Thanks for merging!
I know that feeling ;) |
Yes, now that this issue is out of the way (and the tests are automatically run as part of the CI), I'm going to return to #167 and finish it up by adding a test case. |
+1
Well, I can offer to help out with maintenance a bit, and support @xfischer in this task (if that is desired). Currently you guys are certainly not living up to the promise given in the README ;)
Fortunately it seems like this library is rather stable and does not need a huge amount of maintenance (which is a bit in contrast to the fact that all the latest releases on nuget.org have an -rc suffix). Let me know if I can be of any help ... |
This PR updates the existing GHA config so that it triggers CI jobs for pushes to all branches and all PRs.
You can see a working GHA build based on this branch in my fork: https://github.com/janusw/GeoJSON.Net/actions/runs/7409092782
One can certainly add further extensions to this, but I'm deliberately sticking to the bare minimum that is necessary for triggering successful CI builds here (without any actual source-code changes), so that one has a baseline for further changes.
@xfischer @matt-lethargic Is this ok with you?