Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.0 #181

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Release 1.4.0 #181

merged 1 commit into from
Jul 10, 2024

Conversation

janusw
Copy link
Member

@janusw janusw commented Jul 10, 2024

@xfischer What do you think about preparing a release now? For my taste, 1.4.0 would be an appropriate version number.

This PR sets this version in the csproj, together with some additional minor changes:

  • Updating the copyright year.
  • Removing an outdated PropertyGroup (which refers to net35).
  • Removing the release notes from the csproj (which IMHO is not an ideal place for it). Possible alternatives might be:
    • Adding a ReleaseNotes.md to the repository.
    • Having the release notes on the GitHub Releases page.

What I would do to release this:

  • Merge this PR to master.
  • Set a tag 1.4.0.
  • Let GHA build the package.
  • Upload it to nuget.org (I currently do not have the permissions to do that).

Objections? Comments? Do we need any further changes before the release?

@xfischer
Copy link
Member

Please add your name to the contributors list
Thanks for the release.
Ok for release notes md file.

I'll upload the package. I won't have a lot of bandwidth in the coming days so please be patient.

@xfischer xfischer merged commit 62e6ea8 into GeoJSON-Net:master Jul 10, 2024
2 checks passed
@janusw janusw deleted the release140 branch July 10, 2024 20:16
@janusw
Copy link
Member Author

janusw commented Jul 10, 2024

Thanks for merging! I added the tag and re-triggered GHA. The generated package can be found at:
https://github.com/GeoJSON-Net/GeoJSON.Net/actions/runs/9880734212#artifacts
Could you please upload that to nuget.org, @xfischer ?

@janusw janusw mentioned this pull request Jul 10, 2024
@janusw
Copy link
Member Author

janusw commented Jul 10, 2024

I also created the release here (and attached the nupkg):
https://github.com/GeoJSON-Net/GeoJSON.Net/releases/tag/1.4.0

@xfischer
Copy link
Member

Can you also create the symbol package (snupkg) ?
@matt-lethargic do you have access to the Nuget's GeoJSON.Net organization ? Can you add me as admin so that I can see how to delegate upload rights to @janusw

@janusw
Copy link
Member Author

janusw commented Jul 11, 2024

Can you also create the symbol package (snupkg) ?

Sure, I have attached it to https://github.com/GeoJSON-Net/GeoJSON.Net/releases/tag/1.4.0.

I will also extend the GHA script to build the snupkg as well.

@janusw
Copy link
Member Author

janusw commented Jul 11, 2024

I will also extend the GHA script to build the snupkg as well.

See #182.

@xfischer Do you think you'll be able to upload the package until tomorrow?

If you can give me the permissions, I would do it myself. This is my account: https://www.nuget.org/profiles/janusw

@xfischer
Copy link
Member

Unfortunately I don't have admins rights on nuget. That's why I've asked @matt-lethargic.
I'd be happy to give you proper permissions once this is done.
As said previously I have limited bandwidth for the next days so patience is key now.

@janusw
Copy link
Member Author

janusw commented Jul 11, 2024

Alright, thanks for the comment. Didn't mean to rush you :)

@matt-lethargic
Copy link
Member

Sorting it now @xfischer

@matt-lethargic
Copy link
Member

@xfischer you already are an owner of GeoJSON.NET and I've just invited you to GeoJSON.Text

@janusw
Copy link
Member Author

janusw commented Jul 11, 2024

@matt-lethargic Could you possibly upload release 1.4.0 to nuget.org? Or alternatively give me the permissions to do it myself?

@matt-lethargic
Copy link
Member

I've moved the release process from Azure DevOps and into GHA so that there is better visibility.
Whenever a release is created in GitHub it will now automatically upload to Nuget, this mirrors GeoJSON.Text

As this was created after 1.4.0 I created a new 1.4.1 so that I could get the action to trigger

@janusw
Copy link
Member Author

janusw commented Jul 12, 2024

Awesome, thanks a bunch! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants