Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update dart response to include fake stage #2018

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix: update dart response to include fake stage #2018

merged 1 commit into from
Apr 19, 2024

Conversation

ozym
Copy link
Contributor

@ozym ozym commented Apr 5, 2024 •
edited
Loading

The fake stage is needed for seiscomp to convert the fdsn xml.

Also fixes the multiple channels, due to the sampling rate being in the component aspect.

@ozym ozym requested review from a team as code owners April 5, 2024 02:46
@ozym ozym requested a review from salichon April 5, 2024 02:46
@ozym ozym self-assigned this Apr 5, 2024
@ozym ozym added the dart DART based work label Apr 5, 2024
@ozym
Copy link
Contributor Author

ozym commented Apr 5, 2024

@salichon you could try checking out this branch and then building the stationxml-build program and then running it for a dart station e.g. (go build ; ./stationxml-build -station 'NZE$' -location 42) and see how it looks.

@salichon salichon mentioned this pull request Apr 5, 2024
Closed
@salichon
Copy link
Contributor

salichon commented Apr 5, 2024

@ozym

  • ran ../stationxml-build -station 'NZE$' -location 42 -single -create after go build okay
  • converted properly from stationxml to seiscompxml (fdsnxml2inv and scinv check, scinv ls )
  • indeed looks good
  • yay thanks!

jajera
jajera approved these changes Apr 5, 2024
View reviewed changes
Copy link

@jajera jajera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets do it

@ozym @bpeng
fix: update dart response to include fake stage
a970e94 
The fake stage is needed for seiscomp to convert the fdsn xml.
@ozym ozym merged commit 25cea73 into main Apr 19, 2024
27 checks passed
@ozym ozym deleted the dart branch April 19, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jajera jajera jajera approved these changes

@CallumNZ CallumNZ CallumNZ approved these changes

@salichon salichon salichon approved these changes

Assignees

@ozym ozym

Labels
dart DART based work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ozym @salichon @CallumNZ @jajera