[Backport 4.x][Fixes #968] Adjustments to links inside Share Panel #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyoucanmap
approved these changes
Jun 20, 2022
allyoucanmap
requested changes
Jun 20, 2022
| @@ -130,7 +131,8 @@ function Share({ | |||
| </div> | |||
| <div className="gn-share-panel-body"> | |||
| <SharePageLink url={pageUrl} label={<Message msgId="gnviewer.thisPage" />} /> | |||
| <SharePageLink url={embedUrl} label={<Message msgId={`gnhome.${resourceType}`} />} /> | |||
| <SharePageLink url={embedUrl} label={<Message msgId={`gnviewer.embed${resourceType}`} />} /> | |||
| {resourceType === 'document' && <SharePageLink url={downloadUrl} label={<Message msgId={`gnviewer.directLink`} />} />} | |||
There was a problem hiding this comment.
This backport does not match the commit on master, please use the same commit on master
fe3ddfd#diff-e81b8603dbbf83db9f5f8a705cd5dafc164127477a90240b41072c740eb9e349R145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share links have been adjusted according to #968 (comment)