Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize close buttons for the various panels #720

Merged
merged 1 commit into from
Jan 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
*/

import React, { useRef, useState, useEffect } from 'react';
import { Glyphicon } from 'react-bootstrap';
import FaIcon from '@js/components/FaIcon';
import Button from '@js/components/Button';
import Tabs from '@js/components/Tabs';
Expand Down Expand Up @@ -457,8 +458,8 @@ function DetailsPanel({
variant="default"
href={linkHref()}
onClick={closePanel}
size="sm">
<FaIcon name="times" />
className="square-button">
<Glyphicon glyph="1-close" />
</Button>
</div>
}
Expand Down
6 changes: 3 additions & 3 deletions geonode_mapstore_client/client/js/plugins/Share.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import PropTypes from 'prop-types';
import { connect } from 'react-redux';
import { createSelector } from 'reselect';
import { findIndex } from 'lodash';
import { Glyphicon } from 'react-bootstrap';
import { createPlugin } from '@mapstore/framework/utils/PluginsUtils';
import { setControlProperty } from '@mapstore/framework/actions/controls';
import Message from '@mapstore/framework/components/I18N/Message';
Expand All @@ -28,7 +29,6 @@ import {
getViewedResourceType
} from '@js/selectors/resource';
import { updateResourceCompactPermissions } from '@js/actions/gnresource';
import FaIcon from '@js/components/FaIcon/FaIcon';
import Permissions from '@js/components/Permissions';
import { getUsers, getGroups, getResourceTypes } from '@js/api/geonode/v2';
import { resourceToPermissionEntry, availableResourceTypes, getResourcePermissions } from '@js/utils/ResourceUtils';
Expand Down Expand Up @@ -121,8 +121,8 @@ function Share({
>
<div className="gn-share-panel-head">
<h2><Message msgId="gnviewer.shareThisResource" /></h2>
<Button size="sm" onClick={() => onClose()}>
<FaIcon name="times"/>
<Button className="square-button" onClick={() => onClose()}>
<Glyphicon glyph="1-close"/>
</Button>
</div>
<div className="gn-share-panel-body">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@

#gn-components-theme(@theme-vars) {
.gn-details-panel,
.gn-details-panel > * {
.gn-details-panel > *,
.gn-details-panel-header {
.color-var(@theme-vars[main-color]);
.background-color-var(@theme-vars[main-bg]);
}
Expand Down Expand Up @@ -123,6 +124,9 @@
.gn-details-panel-header {
display: flex;
flex-direction: row-reverse;
position: sticky;
top: 0;
z-index: 10;
}

.gn-details-panel-preview {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,9 @@
flex: 1;
word-break: break-all;
margin: 0;
font-size: 1.5rem;
font-size: 1.4rem;
}
padding: 0.5rem;
margin: 0.5rem;
margin: 0 0.5rem;
}
.gn-share-panel-body {
flex: 1;
Expand Down
114 changes: 111 additions & 3 deletions geonode_mapstore_client/client/themes/geonode/less/ms-theme.less
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,33 @@
@icon-size-md: 15px;
@square-btn-medium-size: 30px;

// **************
// Theme
// **************

#gn-components-theme(@theme-vars) {
.ms-side-panel .ms-header.ms-primary .row:first-child {
.color-var(@theme-vars[main-color]);
.background-color-var(@theme-vars[main-bg]);
.square-button {
.color-var(@theme-vars[main-color], true);
.background-color-var(@theme-vars[main-bg], true);
}
}
}

// **************
// Layout
// **************

.close {
font-size: 16px;
opacity: 1;
}
.modal-header .close {
margin-top: 0;
}

#drawer-menu-button {
z-index: 5;
}
Expand Down Expand Up @@ -77,8 +104,12 @@
// in this specific context those value have different uom
// we should override this to ensure to use rem and have the correct value for padding
.ms-resizable-modal > .modal-content > .modal-header {
height: (@font-size-h4 * 3);
padding: @font-size-h4;
height: auto;
padding: 0.6rem;
}
.modal-header {
height: auto;
padding: 0.6rem;
}
// the input small size is not computed correctly due to rem value
// this override will fix the attribute table filter inputs
Expand Down Expand Up @@ -159,4 +190,81 @@ div#mapstore-globalspinner {

#mapstore-map-footer-container {
z-index: 1100;
}
}

// review drawer menu and toc style

#mapstore-drawermenu {
.nav-content {
display: flex;
flex-direction: column;
position: absolute;
width: 100%;
height: 100%;
.navHeader {
display: flex;
flex-direction: row-reverse;
justify-content: space-between;
min-height: auto !important;
height: auto !important;
}
.nav-body {
flex: 1;
position: relative;
display: flex;
flex-direction: column;
top: 0;
width: 100%;
height: 100%;
margin: 0;
}
.panel,
.panel-body,
.panel-body > div {
position: absolute;
display: flex;
flex-direction: column;
top: 0;
width: 100%;
height: 100%;
margin: 0;
}

}
.mapstore-toc-head {
height: auto !important;
}
.mapstore-toc-head-title-container {
display: none;
}
.mapstore-toc {
flex: 1;
width: 100%;
position: relative;
.mapstore-layers-container {
overflow: auto;
position: absolute;
top: 0;
left: 0;
width: 100%;
height: 100%;
}
}
}

.mapstore-query-builder .m-header {
box-shadow: none;
}

.widgets-builder-header > .row > .text-center {
display: flex;
flex-direction: row-reverse;
> span {
padding: 0 !important;
flex: 1;
}
}

.ms-side-panel .ms-header {
box-shadow: none;
}