Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #6728] SPCGeoNode Dockerfile build error - missing git #6729

Merged

Conversation

ricardogsilva
Copy link
Member

@ricardogsilva ricardogsilva commented Dec 16, 2020

This PR modifies the spcgeonode Dockerfile for django to add git as an additional system dependency. This shall fix #6728

Checklist

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented - does not apply
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode - does not apply
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates - does not apply

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot
Copy link

cla-bot bot commented Dec 16, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @ricardogsilva on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@cla-bot
Copy link

cla-bot bot commented Dec 16, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @ricardogsilva on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@afabiani afabiani changed the title Add git as an additional dependency to spcgeonode django docker image [Fixes #6728] SPCGeoNode Dockerfile build error - missing git Dec 16, 2020
@afabiani afabiani merged commit 4effb0e into GeoNode:master Dec 16, 2020
@afabiani afabiani added this to the 4.0.0 milestone Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPCGeoNode Dockerfile build error - missing git
2 participants