Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #6780] uploading a shapefile with paver setup (and spc) does n… #6816

Merged
merged 4 commits into from
Jan 18, 2021

Conversation

afabiani
Copy link
Member

@afabiani afabiani commented Jan 13, 2021

…ot work

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@afabiani afabiani self-assigned this Jan 13, 2021
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 13, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jan 13, 2021

This pull request introduces 13 alerts when merging 6ee6ad0 into d888a6c - view on LGTM.com

new alerts:

  • 13 for Module-level cyclic import

@t-book
Copy link
Contributor

t-book commented Jan 13, 2021

@afabiani

I've tested the paver setup:

  • Upload layer
  • Upload document
  • add a remote layer

Everything is working smoothly.

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #6816 (cdc5284) into master (d888a6c) will decrease coverage by 0.00%.
The diff coverage is 2.61%.

@@            Coverage Diff             @@
##           master    #6816      +/-   ##
==========================================
- Coverage   51.65%   51.65%   -0.01%     
==========================================
  Files         573      573              
  Lines       40807    40833      +26     
  Branches     5496     5496              
==========================================
+ Hits        21080    21093      +13     
- Misses      18397    18412      +15     
+ Partials     1330     1328       -2     

@afabiani afabiani added this to the 3.2 milestone Jan 15, 2021
@afabiani afabiani merged commit 6aedc9b into master Jan 18, 2021
@afabiani afabiani deleted the ISSUE_6780 branch January 18, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants