Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #6899] Customize metadata template #6894

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Jan 29, 2021

With this PR I want to externalize the catalog metadata template through a settings variable in order to make it easier to configure the template for the metadata

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot
Copy link

cla-bot bot commented Jan 29, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @mattiagiupponi on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@mattiagiupponi mattiagiupponi changed the title [Fixes #2] RNDT: customize metadata teplate [Fixes #2] Customize metadata teplate Jan 29, 2021
@mattiagiupponi mattiagiupponi changed the title [Fixes #2] Customize metadata teplate [Fixes #2] Customize metadata template Jan 29, 2021
@gannebamm
Copy link
Contributor

gannebamm commented Jan 29, 2021

I am aware that this PR is a draft. To get merged it will need some more steps like:

  • The PR has a wrong label
  • Could you please provide an issue with the label feature for this PR?
  • The documentation should show how those templates has to be generated and modified
  • tests?

@mattiagiupponi mattiagiupponi changed the title [Fixes #2] Customize metadata template [Fixes #6899] Customize metadata template Jan 29, 2021
@mattiagiupponi mattiagiupponi added the cla-signed CLA Bot: community license agreement signed label Jan 29, 2021
@mattiagiupponi mattiagiupponi linked an issue Jan 29, 2021 that may be closed by this pull request
5 tasks
@mattiagiupponi mattiagiupponi added the feature A new feature to be added to the codebase label Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #6894 (afcade8) into master (82c8602) will increase coverage by 29.22%.
The diff coverage is 49.00%.

@@             Coverage Diff             @@
##           master    #6894       +/-   ##
===========================================
+ Coverage   22.89%   52.12%   +29.22%     
===========================================
  Files         573      573               
  Lines       40900    40961       +61     
  Branches     5500     5505        +5     
===========================================
+ Hits         9364    21349    +11985     
+ Misses      31203    18268    -12935     
- Partials      333     1344     +1011     

@mattiagiupponi
Copy link
Contributor Author

Hi @gannebamm
Thanks for the comment, I fixed the points in your comment.
Here is the link to the PR for update the documentation.
Any other comment is appreciated

@mattiagiupponi mattiagiupponi marked this pull request as ready for review January 29, 2021 15:00
@afabiani afabiani added this to the 3.2 milestone Jan 29, 2021
@afabiani afabiani merged commit d722888 into GeoNode:master Jan 30, 2021
@afabiani afabiani deleted the ISSUE_#2_rndt_customize_metadata_template branch May 18, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed feature A new feature to be added to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Externalization of the catalog metadata template
4 participants