-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #7194] Append data to an existing layer #7195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiagiupponi
added
the
backport 3.2.x
PR should be backported to target version
label
Mar 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #7195 +/- ##
===========================================
- Coverage 59.07% 25.77% -33.30%
===========================================
Files 565 565
Lines 39827 40156 +329
Branches 5282 5301 +19
===========================================
- Hits 23527 10350 -13177
- Misses 14935 29376 +14441
+ Partials 1365 430 -935 |
afabiani
pushed a commit
that referenced
this pull request
Mar 30, 2021
* [Fixes #7194] Add new append_layer html * [Fixes #7194] Test helper utility for create single layer * [Fixes #7194] Add append data to existing edit layer html * [Fixes #7194] Flake8 formatting * [Fixes #7194] New layer_append url map * [Fixes #7194]Validation helper function for replace and appen layer * [Fixes #7194] Add view for layer_append feature * [Fixes #7194] Test coverage for new validation function (cherry picked from commit b404e0d)
afabiani
pushed a commit
that referenced
this pull request
Mar 30, 2021
* [Fixes #7194] Add new append_layer html * [Fixes #7194] Test helper utility for create single layer * [Fixes #7194] Add append data to existing edit layer html * [Fixes #7194] Flake8 formatting * [Fixes #7194] New layer_append url map * [Fixes #7194]Validation helper function for replace and appen layer * [Fixes #7194] Add view for layer_append feature * [Fixes #7194] Test coverage for new validation function (cherry picked from commit b404e0d) Co-authored-by: mattiagiupponi <51856725+mattiagiupponi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 3.2.x
PR should be backported to target version
cla-signed
CLA Bot: community license agreement signed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to resolve #7194 with this pr I want to:
layer_append
and hisview
create_single_layer
for create only a single layer instead of the 10 created byGeoNodeBaseTestSupport
layer_append
&layer_replace
namedvalidate_input_source
which will check for the compatibility between the layer in upload and the information in the catalog. (with tests)This will check the attributes of the uploaded file and the GS catalog:
gs_append_data_to_layer
which is responsible for theAPPEND
call togeoserver
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.