-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add numpy 2 support #340
Merged
Merged
add numpy 2 support #340
Changes from 30 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
ba5b0d9
Try out numpy 2 beta release
MuellerSeb 3ad422a
Remove py38; use np 2 rc
MuellerSeb 8c52b9a
try running with np 2; remove 32bit wheels
MuellerSeb 7e51f1e
cap black version
MuellerSeb 9618c1c
project: sphinx version fix; black min py version fix
MuellerSeb 4de1557
estimator: use int instead of long
MuellerSeb 7971261
np: use asarray where possible with atleast_Xd to mimic ndmin feature
MuellerSeb 3b35caa
cython: always use 64-bit integers for counts
MuellerSeb bcf22c0
deps: emcee try patch version
MuellerSeb f354999
re-enable py38; np2 to build extensions for py>=3.9; check np2 in CI
MuellerSeb e52cc9b
CI: check several versions of numpy
MuellerSeb 70a59fb
Doc: fix pyvista issue with renaming UniformGrid->ImageData
MuellerSeb 7b8aab3
Doc: use rtd theme >v2
MuellerSeb b3b4fb5
Doc: fix ref issues
MuellerSeb a13968e
CI: try fix missing pip step
MuellerSeb 74b130a
CI: try fix missing pip step by separate job step
MuellerSeb 5f37aee
CI: try fix missing pip step by using env var for version
MuellerSeb ea00a48
CI: try fix missing pip step by using oldest-supported-numpy package
MuellerSeb ebe8ef6
CI: fix missing pip step by using quotes (>= is evil)
MuellerSeb 9074056
CI: install numpy in test stage to ensure version
MuellerSeb dacc89a
deps: bump min np ver to 1.20 (meshio needs np.typing)
MuellerSeb 4353f6e
build: use build dep caps from scipy
MuellerSeb d221248
CI: also fix scipy version
MuellerSeb ba5bfb1
Doc: fix pyvista deprecation warnings
MuellerSeb 552cb58
CI: fix config
MuellerSeb 728adee
fix typo
MuellerSeb 227efb6
update changelog
MuellerSeb 83f8594
finalize pyproject.toml
MuellerSeb 1124580
CI: install scipy/numpy before test to really check compatibility
MuellerSeb 3bff873
update docs with correct deps versions
MuellerSeb 24fd5ca
update actions versions
MuellerSeb 9a754fa
cython: use np.int64_t
MuellerSeb 7b1fd1e
use black 24 and add black preview job to CI
MuellerSeb 062caa8
apply black 24
MuellerSeb 50e6672
fix black preview complain
MuellerSeb 25e002e
CI: emcee 3.1.5 with numpy 2 support was released
MuellerSeb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awful! But I guess there is no other way until py 3.11 is deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly is awful? I think it is pretty neat to test multiple numpy/scipy versions to fix stuff like #246 faster in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a lot of manual (and typo prone?) work. Just imagine we have to add another few packages to that version matrix.
And it also makes it more work to locally reproduce specific setups of users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a new Python version is release we have to add it by hand either way. And then I would just add the first version of numpy and scipy that support that new python version. That is how I selected the numpy and scipy versions for the python version together with a bleeding edge job for the latest versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep it like this for now. If we encounter version incompatibilities in the future, we can rethink this.