Skip to content

Commit

Permalink
change 2 defaults (use_implicit_tiling + geometricerrors)
Browse files Browse the repository at this point in the history
  • Loading branch information
bertt committed Aug 22, 2024
1 parent d1dbf5a commit e459681
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,11 @@ If --username and/or --dbname are not specified the current username is used as
-l, --lodcolumn (Default: '') LOD column (Cesium)
-g, --geometricerrors (Default: 2000,0) Geometric errors (Cesium)
-g, --geometricerrors (Default: 1000,0) Geometric errors (Cesium)
--shaderscolumn (Default: '') shaders column (Cesium)
--use_implicit_tiling (Default: true) use 1.1 implicit tiling (Cesium)
--use_implicit_tiling (Default: false) use 1.1 implicit tiling (Cesium)
--add_outlines (Default: false) Add outlines (Cesium)
Expand Down
3 changes: 3 additions & 0 deletions src/b3dm.tileset/QuadtreeTiler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ public List<Tile> GenerateTiles(BoundingBox bbox, Tile tile, List<Tile> tiles, i
}

tile.Available = bytes != null ? true : false;
if(skipCreateTiles) {
tile.Available = true;
}
tiles.Add(tile);
}

Expand Down
4 changes: 2 additions & 2 deletions src/pg2b3dm/Options.cs
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ public class Options
[Option('l', "lodcolumn", Required = false, Default = "", HelpText = "LOD column (Cesium)", SetName = "Cesium")]
public string LodColumn { get; set; }

[Option('g', "geometricerrors", Required = false, Default = "2000,0", HelpText = "Geometric errors (Cesium)", SetName = "Cesium")]
[Option('g', "geometricerrors", Required = false, Default = "1000,0", HelpText = "Geometric errors (Cesium)", SetName = "Cesium")]
public string GeometricErrors { get; set; }

[Option("use_implicit_tiling", Required = false, Default = true, HelpText = "use 1.1 implicit tiling (Cesium)", SetName = "Cesium")]
[Option("use_implicit_tiling", Required = false, Default = false, HelpText = "use 1.1 implicit tiling (Cesium)", SetName = "Cesium")]
public bool? UseImplicitTiling { get; set; }

[Option("add_outlines", Required = false, Default = false, HelpText = "Add outlines (Cesium)", SetName = "Cesium")]
Expand Down
3 changes: 3 additions & 0 deletions src/wkb2gltf.core/extensions/PointExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ public static Vector3 Minus(this Point p, Point other)
var x = p.X - other.X;
var y = p.Y - other.Y;
var z = p.Z - other.Z;
if (z == null) {
z = 0;
}
return new Vector3((float)x,(float)y,(float)z);
}
}

0 comments on commit e459681

Please sign in to comment.