use rgba hexcodes not argb #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
One improvement: dependency System.Drawing is now only used in two places
It should be possible to remove System.Drawing completely, but that's for another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behaviour: For parsing the hex color codes a ARGB pattern is assumed, with the alpha in the first two characters (in case the hex code is 8 characters)
1] For example: #55FF0000
Becomes Color red (255,0,0) + Alpha = 85
More commonly the RGBA is used:
2] For example #FF000055
Becomes Color red (255,0,0) + Alpha = 85
Fix: Assume the RGBA order not ARGB