Skip to content

Commit

Permalink
editorial fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
lvdbrink committed Feb 26, 2024
1 parent 2f692a6 commit 15b42f9
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 12 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,5 @@ Implemented filtering features by date based on this Openlayers example
https://openlayers.org/en/latest/examples/filter-points-webgl.html

Implemented a JSON-FG format. It is an override of the GeoJSON format.
It add functionality for the global coordRefSys attribute and the "time" and "place" feature attributes.
Implemented a small fix for undefined timestamps. It seems like GDAL generates these values as ".." which is not falsy.
It adds functionality for the global `coordRefSys` attribute and the "time" and "place" feature attributes.
Implemented a small fix for undefined timestamps. GDAL generates these values as ".." which is not falsy. In JSON-FG, the unbounded end of an interval is represented by a double-dot string (".."), see [JSON-FG spec 7.7.4 Intervals](https://docs.ogc.org/DRAFTS/21-045.html#_intervals).
23 changes: 13 additions & 10 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,14 @@
>
</p>
<p>
Notes:<br />
Openlayers has Geojson support but that is not enough for the time and
coordinate system additions of JSON-FG. To make this possible a custom
JSON-FG format is included that partially implements JSON-FG. <br />
The format only supports time.interval from JSON-FG. If it uses
time.date or time.timestamp the timeslider does nothing.
Notes:</p>
<ul>
<li>Openlayers has Geojson support but that is not enough for the time and
coordinate system additions of JSON-FG. To make this possible a custom
JSON-FG format is included that partially implements JSON-FG.</li>
<li>The format only supports <code>time.interval</code>> from JSON-FG. If the data in the JSON-FG editor on the right uses
<code>time.date</code> or <code>time.timestamp</code>, the timeslider does not function.</li>
</ul>
</p>
<p>
GDAL docs on the JSON-FG standard: <br />
Expand All @@ -86,8 +88,8 @@

<p class="subtitle">Create JSON-FG</p>
<p>
Run the following gdal command to convert your gml to json-fg. This
requires gdal >3.8
Run the following GDAL command to convert your GML to JSON-FG. This
requires GDAL >3.8
</p>
<code> ogr2ogr -f "JSONFG" output.jsonfg input.gml </code>
<p>For me it looked like this:</p>
Expand All @@ -96,19 +98,20 @@
./bgt_kunstwerkdeel.jsonfg
https://raw.githubusercontent.com/Geonovum-labs/test-ogc-json-fg/main/testdata/bgt/citygml/bgt_kunstwerkdeel.gml
</code>
<p>It is also possible to use another input format, for example GeoPackage.</p>
</div>

<div class="editor-pane">
<p class="subtitle">JSON-FG editor</p>
<p>Edit your json-fg here, the layer is automatically updated.</p>
<p>Edit your JSON-FG here, the layer is automatically updated.</p>

<div id="jsonfg-editor" class="editor"></div>
</div>

<div class="editor-pane">
<p class="subtitle">Transformation editor</p>
<p>
Add the transformation string for the coordinate system of your json.
Add the transformation string for the coordinate system of your JSON.
</p>
<p>
<!-- Calling it CRS to abstract away all variants of CRS -->
Expand Down

0 comments on commit 15b42f9

Please sign in to comment.