Fix island masking bug #1278
Merged
Fix island masking bug #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
geodata_coast_100k layer(used to define "land" in our ARD styles) has values of 0 (water), 1 (islands) and 2 (land):But for some reason, the
pq_mask_fmask_landmask seems to be using a value of 1 and then inverting it... which seems to be leading to islands being masked but water and land being preserved.This PR attempts to fix this by to change this line to
[0], i.e. water, which should lead to ocean being masked but not land or islands.