Add missing dependencies to setup.py, remove no longer used segmentation.py #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In prep for a new version release of this package, I've cleaned up the
setup.pyfile to add in some missing required packages to ensure it installs nicely on other systems (e.g. outside our NCI and Sandbox environment).As part of this, I removed the
segmentation.pyfile from the repo as we no longer use it anywhere in DEA Notebooks since we stopped usingRSGISlibfor segmentation. It included a bunch of complex dependencies, so removing it will hopefully make installingdea_toolsmuch easier for external users.