Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract coastline app from product notebook and move to Interactive_apps #1032

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Extract coastline app from product notebook and move to Interactive_apps #1032

merged 1 commit into from
Apr 12, 2023

Conversation

robbibt
Copy link
Member

@robbibt robbibt commented Apr 12, 2023 •
edited
Loading

Proposed changes

The coastline transect extraction tool currently lives at the bottom of the DEA_products/DEA_Coastlines.ipynb notebook.

Now that we have a new Interactive_apps folder, this PR extracts the tool and moves it there instead as a new Interactive_apps/Coastal_transects.ipynb notebook!

image

Checklist (replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@robbibt robbibt requested review from vnewey and erialC-P April 12, 2023 02:59
@robbibt robbibt marked this pull request as ready for review April 12, 2023 02:59
erialC-P
erialC-P approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@erialC-P erialC-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really exciting and a great demonstration of how powerful the interactive notebooks can be for a major pool of DEA users. Awesome!

@robbibt robbibt merged commit 75a63ad into develop Apr 12, 2023
@robbibt robbibt deleted the coastlines_app branch April 12, 2023 03:59
erin-telfer added a commit that referenced this pull request May 1, 2023
@erin-telfer @BexDunn
@treefern @pindge @Matt-dea @LaurenSchenk1 @robbibt @mdasi00 @erialC-P
pulling dev into matt's branch (#1046)
0a54a06 
* Readme update (#1019)

* test this

* permalink to the template notebook

* trying to get the link working

* Update README.rst

* Update README.rst

---------

Co-authored-by: Nathan <95725385+treefern@users.noreply.github.com>

* upgrade docker-compose postgres image version to 13

* Update bandindices.py (#1022)

Added Normalised Difference Turbidity Index to the 'calculate_indices' tool.
NB. acronym 'NDTI' is already in use for Tillage Index. Acronym 'TI' used in lieu.

* Readme Update (#1025)

Updating to include link back to wiki for approving/reviewing pull requests.

* Tiny doc update to remote build trigger (#1026)

* Update trigger_docs.yaml

Add explanation of triggering build in other doc repo

* Formatting suggestions from review

* Fix `pixel_tides` issues when `ds` has no time dimension (#1028)

* Update pixel_tides func to cover edge cases

* Sync with develop branch

* Hard code dimension order instead of getting dims from ds

* Clean code

* Update USAGE.rst (#1029)

I've added a recently accepted manuscript where I used DEA to calulcate Geomedians and show landscape changes. And the relevant years where we've used DEA sandbox in our remote sensing topics at Flidners university.
Additionally added a conference presentation from AEO22 from Earth Observation Australia 2022 in Brisbane,

* Update spellcheck_wordlist.txt

* Update DEA Notebooks directory structure (#1027)

* New interactive apps folder, moved appropriate notebooks inside

* Deleted scientific_workflows

* rename DEA_datasets folder to DEA_products

* updated 17 notebook references from DEA_datasets to DEA_products

* Rename frequently used code

* Fix incorrect repo folders

* Revert to before dir rename

* Rename frequently used code

* Update readme for DEA_products and How_to_guides

* replace notebook references to Frequently_used_code with How_to_guides

* replace notebook references to frequently used code with How_to_guides

* replaced notebook references to DEA_datasets

* Add readme to interactive apps

* updated Real_world_examples readme

* Remove defunct tests (replaced by nbval --lax)

* Update readme to include interactive apps

* Use stable branch

* Update real world examples format

* Update guided tutorial link

* Update template to remove mention of scientific workflows and Scripts dir

* Fix formatting

* Fix formatting

* Last attempt to fix template notebook formatting

* Final final fix of formatting

---------

Co-authored-by: erialC-P <claire.phillips@ga.gov.au>

* Fix geocoding func to still work if geocoding service is down (#1030)

* Fix geocoding func to still work if geocoding service is down

* Fix format

* Extract coastline app from product notebook and move to Interctive_apps (#1032)

* Update spellcheck_wordlist.txt (#1037)

add:
Ai
Fanson
Fickas
Ronan

* Update USAGE.rst (#1036)

Added Wetlands paper!!

* Replace conference paper with Wetlands paper (#1034)

updated citation list with paper

* Update plotting.py

Added a tool named 'plot_variable_images' primarily for use in the "Burnt_area_mapping_near_real_time" notebook.

* Update plotting.py

* Update plotting.py

* small correction to new tool in plotting.py

Added extra check to handle error when the input xarray dataset has 0 images.

* Update plotting.py

Actioned suggestion to raise error.

* Add Sentinel-2 and Landsat option to animation notebook (#1043)

* Add Sentinel-2 and Landsat option to animation notebook

* Set default resolutions

* Fix bug where choosing combined product didn't trigger data reload

* Update functions to use `odc-geo` and add additional content to tests (#1039)

* Make geobox adding func more generic

* Remove deprecated map_shapefiles func and replace with .explore

* Use odc-geo geobox in xr_animation

* Add geomedian collection option to calculate_indices

* Update animation notebook to use geomedian so we can add it to tests

* Update tests to run on animation notebook

* Fix collection number in segmentation notebook

* Update rgb func to use odc-geo

* Fix attributes being dropped by xr.where, update deprecation version

* Remove assign_crs from rgb (not needed), and add error handling to xr_animation

* Use better error

* Re-run affected notebooks

* Update collection param in ML notebooks

* Add manual reload trigger to layer selection (#1044)

---------

Co-authored-by: Bex Dunn <BexDunn@users.noreply.github.com>
Co-authored-by: Nathan <95725385+treefern@users.noreply.github.com>
Co-authored-by: Pin Jin <pindge.j@gmail.com>
Co-authored-by: Pin Jin <pin.jin@ga.gov.au>
Co-authored-by: Matt-dea <129345253+Matt-dea@users.noreply.github.com>
Co-authored-by: LaurenSchenk1 <125851593+LaurenSchenk1@users.noreply.github.com>
Co-authored-by: Robbi Bishop-Taylor <Robbi.BishopTaylor@ga.gov.au>
Co-authored-by: mdasi00 <91014391+mdasi00@users.noreply.github.com>
Co-authored-by: erialC-P <claire.phillips@ga.gov.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erialC-P erialC-P erialC-P approved these changes

@vnewey vnewey Awaiting requested review from vnewey vnewey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbibt @erialC-P