Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

water quality suspended matter notebook #1146

Merged
merged 4 commits into from
Oct 3, 2023
Merged

water quality suspended matter notebook #1146

merged 4 commits into from
Oct 3, 2023

Conversation

JM-GA
Copy link
Collaborator

@JM-GA JM-GA commented Sep 27, 2023

Proposed changes

Include water quality suspended matter notebook from DEA Africa

Closes issues (optional)

Checklist (replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@geoscience-aman geoscience-aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks @JM-GA! All my changes are optional.

Maybe we also want to add this notebook to Real_world_examples/README.rst.

JM-GA added 2 commits October 3, 2023 10:33
add Aman code for colourbar for water quality notebook
@JM-GA
Copy link
Collaborator Author

JM-GA commented Oct 3, 2023

Thanks for the review @geoscience-aman and for the great code revision re visualisation of results!

@JM-GA JM-GA merged commit 7e38eb0 into develop Oct 3, 2023
2 checks passed
@JM-GA JM-GA deleted the water_quality branch October 3, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Wetland Turbity notebook from DE Africa 💧
2 participants