Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed all 'Github' to 'GitHub' #1203

Merged

Conversation

benji-glitsos-ga
Copy link
Collaborator

Proposed changes

Since 'GitHub' is the proper capitalisation, I corrected all instances of 'Github' throughout the dea-notebooks repo - this includes changing instances within the Notebooks as well as the Tools code comments (but not within the Python code itself).

Note: We should merge this as soon as possible to avoid merge conflicts.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted pending the test run (it failed but may clear up when it runs again)

Copy link
Collaborator

@BexDunn BexDunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Benji, happy for you to go ahead and merge. Thanks for doing this stuff, it all counts :) I'm not sure whether it would be worthwhile to update the last modified dates on the notebooks, given it's a nice (but relatively minor) change, and I think better not to change the last modified date as it may make people feel that individual notebooks have been reviewed more recently than they have? So happy for this one to go through asap :)

@robbibt
Copy link
Member

robbibt commented Mar 7, 2024

I reckon leave them as they are for now - they're most useful for code changes (e.g. knowing that the code last ran OK on date X). 🙂

@benji-glitsos-ga
Copy link
Collaborator Author

Ok great. Thanks for reviewing - I can merge this now.

@benji-glitsos-ga benji-glitsos-ga merged commit 481caa1 into develop Mar 7, 2024
1 check passed
@benji-glitsos-ga benji-glitsos-ga deleted the feature/standardising-github-capitalisation branch March 7, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants