Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEA Waterbodies notebook for v3, closes issue #1200 #1207

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

BexDunn
Copy link
Collaborator

@BexDunn BexDunn commented Mar 12, 2024

Proposed changes

updates the DEA Waterbodies notebook for v3, closing issue #1200

Closes issues (optional)

Checklist

(Replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@BexDunn BexDunn merged commit e6781fc into develop Mar 12, 2024
1 check passed
@BexDunn BexDunn deleted the wb_v3_nb_fix branch March 12, 2024 05:36
BexDunn added a commit that referenced this pull request Mar 12, 2024
…ies v3.0 (#1209)

* Updates to DEA Waterbodies notebooks and tools for v3.0 (#1199)

* start editing, change modified date

* update v2 to v3

* update examples to v3

* add new image to DEA Waterbodies notebooks

* rerun prior to PR

* add @whatnick 's version support for v2 and v3

* change heading size for disclaimer text

* include back compatibility in waterbodies.py script and pt and propagate to waterbodies notebooks

* add header image and move disclaimer to info box

* update links to knowledge hub

* check knowledgehub links'

* rollback to develop to fix merge conflict

* reapply changes, and update knowledge hub links and GitHub references

* having to roll back again because of merge conflicts

* DEA Waterbodies notebook for v3, closes issue #1200 (#1207)

* add citation to usage.rst (#1208)

* add citation 

closes #1179

* Update USAGE.rst

Co-authored-by: Robbi Bishop-Taylor <Robbi.BishopTaylor@ga.gov.au>

---------

Co-authored-by: Robbi Bishop-Taylor <Robbi.BishopTaylor@ga.gov.au>

---------

Co-authored-by: Robbi Bishop-Taylor <Robbi.BishopTaylor@ga.gov.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants