Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up WIT notebook #1244

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Speed up WIT notebook #1244

merged 3 commits into from
Jul 15, 2024

Conversation

BexDunn
Copy link
Collaborator

@BexDunn BexDunn commented Jul 11, 2024

Proposed changes

  • Reduced the time period for execution from two years to one year
  • Added and documented the ability to have months on the graphs instead of years
  • Removed a hard-coded infer_datetime parameter, as pandas doesn't need it anymore and warns if you include it
  • added explicit dask chunks

This could probably still go faster, I'm not sure why I'm loading into memory so early here. But this should make a big difference for testing in the meantime

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@BexDunn BexDunn requested a review from LaurenSchenk1 July 11, 2024 07:41
Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BexDunn, this looks great. For the Dask chunking, I think you can set the x and y chunks to something bigger and it will still have the same effect (Dask will clip the chunks back to the size of your data): e.g. "x": 2048, "y": 2048. That way it will be more generic to other areas/extents in the future (but hopefully still keep the spatial chunking you've set here for this example).

@BexDunn BexDunn requested a review from robbibt July 15, 2024 04:20
Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@robbibt robbibt merged commit 6dffa38 into develop Jul 15, 2024
1 check passed
@robbibt robbibt deleted the WIT_speedup branch July 15, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants