Support for FES2014 tide model via CNES aviso-fes. #919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
A drop-in alternative to the OTPS tide model in
Tools/dea_tools/coastal.py
which defaults to OTPS and then tries to useaviso-fes
, if installed, to calculate tide heights. It is coded as a newpyfes_model.py
with the same method signatures as the current code to allow seamless swapping without changes to the current code. However, the user needs to set theFES2014_OCEAN_INI
environment variable as explained in the docstring for the module.An example of use is provided in
Real_world_examples/Coastal_erosion.ipynb
.Closes issues (optional)
Checklist (replace
[ ]
with[x]
to check off)Load packages
General advice
)jupyterlab_code_formatter
tool can be used to format code cells to a consistent style: select each code cell, then clickEdit
and then one of theApply X Formatter
options (YAPF
orBlack
are recommended).NCI
andDEA Sandbox
(flag if not working as part of PR and ask for help to solve if needed)Notebook currently compatible with the NCI|DEA Sandbox environment only
line below the notebook title to reflect the environments the notebook is compatible with