Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimise test github action #920

Merged
merged 7 commits into from
May 23, 2022
Merged

optimise test github action #920

merged 7 commits into from
May 23, 2022

Conversation

pindge
Copy link
Contributor

@pindge pindge commented May 23, 2022

Proposed changes

the current test github action workflow isn't working correctly. This pr fixes and optimises the following:

  • the s3-to-dc command is only available in index image,
  • the setup_test_datacube.sh need to be mounted to index container
  • execute the setup_test_datacube.sh from the container directly
  • directly execute s3-to-dc command in setup_test_datacube.sh
  • clone the latest dea-config to load all the product metadata and metadata type

Closes issues (optional)

Checklist (replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

@pindge pindge requested a review from robbibt May 23, 2022 01:45
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thanks @pindge!

@robbibt robbibt merged commit ca34fac into develop May 23, 2022
@robbibt robbibt deleted the optimise-test-ci branch May 23, 2022 05:29
@pindge pindge linked an issue May 23, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-compose relies on out of date setup
2 participants