Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterbodies fix #932

Merged
merged 4 commits into from
Aug 1, 2022
Merged

Waterbodies fix #932

merged 4 commits into from
Aug 1, 2022

Conversation

vnewey
Copy link
Collaborator

@vnewey vnewey commented Aug 1, 2022

Updated code to use DEA Waterbodies V2

vnewey added 4 commits August 1, 2022 12:15
Update geohash example to v2 eg r3dn23wh1_v2
Updating the wfs name from DigitalEarthAustraliaWaterbodies to DigitalEarthAustraliaWaterbodies_v2
updated deprecated xarray.reduce() methods
@vnewey vnewey requested a review from BexDunn August 1, 2022 04:46
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@BexDunn BexDunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully I haven't broken anything in approving this one :)

@vnewey vnewey merged commit d5dc866 into develop Aug 1, 2022
@vnewey vnewey deleted the waterbodies_fix branch August 1, 2022 04:58
@robbibt
Copy link
Member

robbibt commented Aug 1, 2022

At some point it would be great to add some tests to the DEA Waterbodies code - given it doesn't need datacube access to access the data it should be a bit more straightforward than some of our other notebooks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants