Skip to content

Commit

Permalink
Enable ImmutableAnnotationChecker
Browse files Browse the repository at this point in the history
The following issue has been fixed and check can be enabled:
google/error-prone#1348

Change-Id: I4caa6b4f54efa3d68d8e2c35a9e7f8b1871f3ca8
  • Loading branch information
gdmfilippov committed Sep 23, 2021
1 parent e32f4e8 commit 7d49381
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions tools/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ default_java_toolchain(
# enabled. This warnings list is originally based on:
# https://github.com/bazelbuild/BUILD_file_generator/blob/master/tools/bazel_defs/java.bzl
# However, feel free to add any additional errors. Thus far they have all been pretty useful.
# TODO(davido): Enable ImmutableAnnotationChecker again when these issues are fixed:
# https://github.com/google/error-prone/issues/1348
# https://github.com/bazelbuild/bazel/issues/9378
java_package_configuration(
name = "error_prone",
javacopts = [
Expand Down Expand Up @@ -99,7 +96,7 @@ java_package_configuration(
"-Xep:FunctionalInterfaceClash:ERROR",
"-Xep:FutureReturnValueIgnored:ERROR",
"-Xep:GetClassOnEnum:ERROR",
"-Xep:ImmutableAnnotationChecker:OFF",
"-Xep:ImmutableAnnotationChecker:ERROR",
"-Xep:ImmutableEnumChecker:ERROR",
"-Xep:IncompatibleModifiers:ERROR",
"-Xep:InjectOnConstructorOfAbstractClass:ERROR",
Expand Down

0 comments on commit 7d49381

Please sign in to comment.