Fix both success and failure message being shown if installation fails

References #460
Gert-dev · Sep 14, 2019 · 9e563b1 · 9e563b1
1 parent 5bfc51b
commit 9e563b1
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/SerenataClient.js b/lib/SerenataClient.js
@@ -85,9 +85,7 @@ class SerenataClient extends AutoLanguageClient
                             notification.dismiss();
 
                             const callback = async () => {
-                                try {
-                                    await this.installServer();
-                                } catch (e) {
+                                if (!await this.installServer()) {
                                     reject(new Error('Server installation failed'));
                                     return;
                                 }
@@ -148,6 +146,8 @@ class SerenataClient extends AutoLanguageClient
                 description: message,
                 dismissable: true,
             });
+
+            return false;
         }
 
         atom.notifications.addSuccess('Serenata - Server Installation Succeeded', {dismissable: true});