Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows config setup #479

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Conversation

UziTech
Copy link
Contributor

@UziTech UziTech commented Oct 1, 2019

When initially setting up the new config file in windows we need to escape any backslashes in the folder path

before:

{
    "uris": [
        "file://C:\folder"
    ],
    "indexDatabaseUri": "file://C:\Users\user\AppData\Roaming\php-ide-serenata\index-5c51a4ab6ab1bda8bf0d2e20c0bdc99f.sqlite",
    "phpVersion": 7.3,
    "excludedPathExpressions": [],
    "fileExtensions": [
        "php"
    ]
}

after:

{
    "uris": [
        "file://C:\\folder"
    ],
    "indexDatabaseUri": "file://C:\\Users\\user\\AppData\\Roaming\\php-ide-serenata\\index-5c51a4ab6ab1bda8bf0d2e20c0bdc99f.sqlite",
    "phpVersion": 7.3,
    "excludedPathExpressions": [],
    "fileExtensions": [
        "php"
    ]
}

@Gert-dev
Copy link
Owner

Gert-dev commented Oct 1, 2019

Thanks for taking the time to fix issues with this package on Windows. LGTM!

@Gert-dev Gert-dev merged commit b47a7bd into Gert-dev:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants