-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply round of code quality improvements from Rector #4038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I think we'll hold off on merging till we have a 2.17 release ready, which will include PHP 8.2 support and dropping PHP 7.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready I think. Just one thing, I think the title/commit message is a little unclear. Can we make it something like "Apply round of code quality improvements from Rector" or something?
Use Drupal-Rector to do the following:
str_starts_with()
, etc.Currently excludes
data_dictionary_widget
to avoid merge issues.