-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Dictionary Field Widget #4138
Conversation
dfe08fc
to
2892eec
Compare
9bf08e5
to
722d69d
Compare
Validation for the form fields coming soon! |
2534648
to
65ef95a
Compare
The codeclimate issue is out of our control as it's a function provided by Drupal core. Details |
2e5ddb8
to
530100f
Compare
…lds for the field_json_metadata data node to collect information for the data-dictionary
…tionary-Field-Widget
…, added twig template for the output of the table to handle formatting of the table fields
…submit callbacks, adjusted custom-table
…m before validation
…loads a new data dictionary widget and verifies that the identifier, title and data dictionary section exists.
… a new data dictionary field
…r the data dictionary fields
…some code to satisfy code climate
…ictionary field, added a new test to update a field and save the edited data dictionary field
… classes placed in the Fields folder, Fixed the file name and yml structure of the libraries.yml file, moved css folder and file into the module root, added code in .module to attach the library and css because it was originally not loading on the data dictionary form.
…ield values after a form state rebuild where validation errors get triggered
…ost and have somewhere to live in the field_json_metadata. Once index features are built this can be refactored.
…nary indexes to persist, updated the widget to save the indexes if one exists, small bug fix with the cancel button
…w a randomly generated UUID, Code cleanup.
530100f
to
1f586e4
Compare
Tested and working on a new build as well as an upgrade to existing data dictionaries. ℹ️ Note for existing users. |
fixes [org/repo/issue#]
QA Steps
Let's first make sure that existing data dictionaries created before this new widget continue to work as usual.
{"identifier":"Index Test","data":{"title":"Index Test","fields":[{"name":"reactivation_date","title":"Reactivation Date","type":"date","format":"%m/%d/%Y","format_other":"%m/%d/%Y","description":"The Reactivation Date"},{"name":"market_date","title":"Market Date","type":"date","format":"%m/%d/%Y","format_other":"%m/%d/%Y","description":"The Market Date"}],"indexes":[{"fields":[{"name":"decision_rationale"},{"name":"coverage_rules"}],"type":"fulltext","description":"idx1"},{"fields":[{"name":"decision","length":15}],"type":"index","description":"idx2"},{"fields":[{"name":"appeal_type","length":30}],"type":"index","description":"idx5"}]}}
This module is a dependency in DKAN and should automatically install if you run 'ddev composer install' or 'ddev drush en data_dictionary_widget'.
This module adds a new widget that automatically engages in the form when creating/editing/viewing data-dictionaries.
Begin QA of new widget:
To begin let's be sure that this module does not affect any of the other forms built via the json_form_widget module.
Confirm data-dictionary form displays:
Confirm dataset form displays:
Navigate to /node/add/data?schema=dataset
You may continue testing other schema's if needed.
Now lets test the data-dictionary widget form:
This is the UUID of this Data Dictionary. To assign this data dictionary to a specific distribution use this {{URL}}.
Let's confirm that the new data dictionary you just created can be used for the sitewide dictionary.
Let's create a simple dataset:
Continue testing the data dictionary form: