-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
19105 Use Drupal entity API for harvest_runs table, with refactor #4144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto 19105-harvest-runs-entity
paul-m
changed the title
19105 Use Drupal entity API for harvest_runs table, bonus points
19105 Use Drupal entity API for harvest_runs table, full refactor
Apr 4, 2024
paul-m
changed the title
19105 Use Drupal entity API for harvest_runs table, full refactor
19105 Use Drupal entity API for harvest_runs table, with refactor
Apr 4, 2024
3 tasks
dafeder
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have a winner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
harvest_run
. This entity has the following features:extracted_uuid
load_new_uuid
load_updated_uuid
load_unchanged_uuid
orphan_uuid
data
.HarvestService::getAllHarvestRunInfo()
only need the IDs, so addHarvestService::getAllHarvestRunIds()
so we can just do an entity query for IDs without the overhead of loading entities or parsing JSON.HarvestRunRepository
for ease of calling betweenHarvestService
andHarvestRun
entity methods.HarvestService
to use new run repo.HarvestUtility
for the new run repo.