Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4208: New permission for administering metastore settings #4209

Merged
merged 1 commit into from
Jul 2, 2024
Merged

#4208: New permission for administering metastore settings #4209

merged 1 commit into from
Jul 2, 2024

Conversation

stefan-korn
Copy link
Contributor

fixes #4208

  • Test coverage exists
  • Documentation exists

QA Steps

  • check permissions under admin/people/permissions at section Metastore and see the new permission 'Metastore: Administer Metastore Settings"
  • grant this permission to a role
  • check that the role with this permission can access admin/dkan/properties
  • check that a role without this permission cannot access admin/dkan/properties

dafeder
dafeder approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes discussed this at last team meeting and all agree this makes sense. We'll put something in the release notes to flag it since it could mean users lose access to this after update.

@dafeder dafeder merged commit fb7dfd9 into GetDKAN:2.x Jul 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafeder dafeder dafeder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] New permission for administering metastore settings
2 participants
@stefan-korn @dafeder