Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert DkanDocsTest to BTB #4245

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Convert DkanDocsTest to BTB #4245

merged 3 commits into from
Aug 2, 2024

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Aug 2, 2024

No description provided.

@paul-m paul-m marked this pull request as ready for review August 2, 2024 22:15
dmundra
dmundra approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@dmundra dmundra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code cleanup looks good and the tests were passing with 78% code coverage, the last changes bumped that to 100% so I think good to go once tests are confirmed to be passing in latest pipeline.

@dmundra dmundra merged commit 70e15d9 into 2.x Aug 2, 2024
10 checks passed
@dmundra dmundra deleted the 16981-dkandocstest-btb branch August 2, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmundra dmundra dmundra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-m @dmundra