Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes misalignment of import dashboard #4270

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Sep 1, 2024

Fixes [issue#]

Describe your changes

The import status dashboard has suffered from misalignment issues because datastore nodes can have the publish status of 'hidden.'
This gets set in CSS as class=hidden, which just hides the table cell.

The fix is to change the class used to style the table cell.

QA Steps

  • Set up a sample content site:
ddev dkan-site-install
ddev drush pm-enable sample_content
ddev drush dkan:sample-content:create
ddev drush cron
ddev drush cron
  • Log in: ddev drush uli
  • Visit the import status page at admin/dkan/datastore/status
  • Pick a dataset. I suggest Florida Bike Lanes.
  • Visit it's edit page... DKAN -> Datasets -> find bike lanes -> click Edit.
  • Change its published status to 'Published (hidden)'
  • Revisit the import status page (admin/dkan/datastore/status). The table will not be misaligned.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@paul-m paul-m marked this pull request as ready for review September 4, 2024 15:54
@dmundra dmundra self-requested a review September 4, 2024 16:10
Copy link
Contributor

@dmundra dmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution looks good and works.

@dmundra dmundra merged commit c31334e into 2.x Sep 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants