Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DKAN-4278 Remove upload_or_link length validation #4279

Merged
merged 1 commit into from
Sep 9, 2024
Merged

DKAN-4278 Remove upload_or_link length validation #4279

merged 1 commit into from
Sep 9, 2024

Conversation

swirtSJW
Copy link
Contributor

@swirtSJW swirtSJW commented Sep 9, 2024 •
edited
Loading

Fixes #4278

Describe your changes

QA Steps

  • Create or edit a dataset with a remote url.
  • Save the dataset
  • validate that the save took place (no big scary error about mb_strlen only allowing strings, not arrays.)

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@janette janette merged commit 1a993fb into 2.x Sep 9, 2024
11 checks passed
@janette janette deleted the DKAN-4278-fix-upload-link-validation branch September 9, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janette janette janette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mb_strlen() error when saving an upload_or_link url
2 participants
@swirtSJW @janette