Merge pull request #3 from GetFeedback/fix/gfpcol-2191/fix-asynchroni…

…city [GFPCOL-2191] fix asynchronicity
GetFeedback · Sep 2, 2021 · ae2679e · ae2679e
2 parents d52b592 + febffea
commit ae2679e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/lightningjs-embed.js b/lightningjs-embed.js
@@ -100,13 +100,14 @@ window.lightningjs || (function(modules){
                     // this helper is used to build the inner iframe where
                     // the module will live in its own window context
                     function buildInnerFrameHtml() {
-                        return [
-                            "<head></head><",body, "'\"></", body, ">"
-                        ].join("")
+                      return [
+                        "<head></head><",body,"><",script," src=\"", internalModule.l,"\"></",script,"></", body,">",
+                      ].join("");
                     }
 
                     // try to get a handle on the document body
                     var body = "body",
+                    script = "script",
                     documentBody = theDocument[body];
 
                     // if the document body does not exist yet, wait 100ms
@@ -173,11 +174,6 @@ window.lightningjs || (function(modules){
                         var frameDocument = innerFrame[contentWindow][documentString];
                         frameDocument.write(buildInnerFrameHtml());
                         frameDocument.close();
-                        if (innerFrame.addEventListener) {
-                            innerFrame.addEventListener('load', loadScript);
-                        } else {
-                            innerFrame.attachEvent('onload', loadScript);
-                        }
                     } catch(D) {
                         innerFrame[srcAttr] = domainSrc + 'd.write("' + buildInnerFrameHtml().replace(/"/g, String.fromCharCode(92) + '"') + '");d.close();'
                     }

diff --git a/lightningjs-embed.min.js b/lightningjs-embed.min.js