Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOB-30658 Add ability to set authorization headers #1

Merged
merged 5 commits into from
May 5, 2021

Conversation

ryanb-jobber
Copy link
Collaborator

@ryanb-jobber ryanb-jobber commented May 3, 2021

Adds the ability to add headers to the API calls. This will be used to authorize the calls to our proxy server.

Based on FaridSafi#660 but made more generic to support arbitrary headers.

To test, you can update the dependency in your jobber-mobile package.json to

"@jobber/react-native-google-places-autocomplete": "GetJobber/react-native-google-places-autocomplete#JOB-30658/add-auth-headers",

And then try supplying a header like so:

            requestUrl={{
              url: "",
              useOnPlatform: "web",
              headers: {
                "myheader": "test",
              },
            }}

@cwtedwards
Copy link

Oh it looks like I never put this into review, apologies!

  • can see headers on the request

LGTM

@cwtedwards cwtedwards added APPROVED and removed PTAL labels May 5, 2021
@ryanb-jobber ryanb-jobber merged commit fd4ce36 into master May 5, 2021
@ryanb-jobber ryanb-jobber deleted the JOB-30658/add-auth-headers branch May 5, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants