Merge pull request #104 from GetLuko/hc/fix/set-mini-by-default-butto…

…n-bar ButtonBar: force size mini on button bar + update test id
GetLuko · Aug 17, 2023 · 3093a91 · 3093a91
2 parents d910c70 + 8c6c78c
commit 3093a91
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/packages/sandbox/src/app/sandbox/docs/button-bar.doc.tsx b/packages/sandbox/src/app/sandbox/docs/button-bar.doc.tsx
@@ -6,31 +6,26 @@ const buttonsArray: ButtonProps[] = [
     text: 'One',
     onPress: () => console.log('onPress One'),
     iconName: 'Area',
-    size: 'mini',
   },
   {
     text: 'Two',
     onPress: () => console.log('onPress Two'),
     iconName: 'Area',
-    size: 'mini',
   },
   {
     text: 'Three',
     onPress: () => console.log('onPress Three'),
     iconName: 'Area',
-    size: 'mini',
   },
   {
     text: 'Four',
     onPress: () => console.log('onPress Four'),
     iconName: 'Area',
-    size: 'mini',
   },
   {
     text: 'Five',
     onPress: () => console.log('onPress Five'),
     iconName: 'Area',
-    size: 'mini',
   },
 ];
 

diff --git a/packages/streamline/package.json b/packages/streamline/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@getluko/streamline",
-  "version": "0.0.29",
+  "version": "0.0.30",
   "author": "luko",
   "description": "Luko Design System using react-native for iOS and Android",
   "main": "dist/packages/streamline/index.js",

diff --git a/packages/streamline/src/components/button-bar/button-bar.spec.tsx b/packages/streamline/src/components/button-bar/button-bar.spec.tsx
@@ -48,7 +48,7 @@ describe('ButtonBar', () => {
     const { getByTestId } = renderWithProvider(
       <ButtonBar buttons={[]} isSkeleton testID="ButtonBar" />
     );
-    const scrollView = getByTestId('ButtonBar_container');
+    const scrollView = getByTestId('ButtonBar');
 
     expect(scrollView.props).toHaveProperty('scrollEnabled', false);
   });

diff --git a/packages/streamline/src/components/button-bar/button-bar.tsx b/packages/streamline/src/components/button-bar/button-bar.tsx
@@ -7,7 +7,7 @@ import { Button } from '../buttons/button/button';
 import { ButtonProps } from '../buttons/button/button.types';
 
 type Props = {
-  buttons: ButtonProps[];
+  buttons: Omit<ButtonProps, 'size'>[];
   isSkeleton?: boolean;
   testID?: string;
 };
@@ -28,7 +28,7 @@ export const ButtonBar = ({ buttons, isSkeleton = false, testID }: Props) => {
 
   return (
     <ScrollView
-      testID={testID ? `${testID}_container` : undefined}
+      testID={testID}
       scrollEnabled={!isSkeleton}
       horizontal={true}
       showsHorizontalScrollIndicator={false}
@@ -46,6 +46,7 @@ export const ButtonBar = ({ buttons, isSkeleton = false, testID }: Props) => {
             appearance="secondary"
             {...button}
             isSkeleton={isSkeleton}
+            size="mini"
           />
         </Box>
       ))}