Skip to content

Commit

Permalink
chore(Pressable): replace react-native with react-native-ama for acce…
Browse files Browse the repository at this point in the history
…ssible Pressable (#151)

* chore(Pressable): replace react-native with react-native-ama for accessible Pressable

* reapply patch to fix test

* revert: yarn version package.json

---------

Co-authored-by: Hugo Courthias <hugo.courthias@gmail.com>
  • Loading branch information
judastheo and hcourthias authored Feb 21, 2024
1 parent 0285358 commit 3695202
Show file tree
Hide file tree
Showing 6 changed files with 4,296 additions and 4,308 deletions.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"prettier": "^2.0.5",
"react": "18.2.0",
"react-native": "0.72.10",
"react-native-ama": "0.6.20",
"react-native-ama": "0.7.5",
"react-native-builder-bob": "^0.20.0",
"react-native-gesture-handler": "~2.12.0",
"react-native-reanimated": "~3.3.0",
Expand All @@ -70,7 +70,7 @@
"@types/react": "17.0.21",
"react-native-reanimated@~3.6.2": "patch:react-native-reanimated@npm%3A3.6.2#./.yarn/patches/react-native-reanimated-npm-3.6.2-188483b50f.patch",
"react-native-reanimated@~3.3.0": "patch:react-native-reanimated@npm%3A3.6.2#./.yarn/patches/react-native-reanimated-npm-3.6.2-188483b50f.patch",
"react-native-ama@0.6.20": "patch:react-native-ama@npm%3A0.6.20#./.yarn/patches/react-native-ama-npm-0.6.20-6174f89a1f.patch"
"react-native-ama@0.7.5": "patch:react-native-ama@npm%3A0.6.20#./.yarn/patches/react-native-ama-npm-0.6.20-6174f89a1f.patch"
},
"peerDependencies": {
"@react-native-community/datetimepicker": "7.6.1",
Expand All @@ -81,7 +81,7 @@
"libphonenumber-js": "^1.10.55",
"react": "18.2.0",
"react-native": "0.72.10",
"react-native-ama": "0.6.20",
"react-native-ama": "0.7.5",
"react-native-gesture-handler": "~2.12.0",
"react-native-reanimated": "~3.3.0",
"react-native-safe-area-context": "4.8.2",
Expand Down
2 changes: 1 addition & 1 deletion sandbox/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"react": "18.2.0",
"react-dom": "18.2.0",
"react-native": "0.73.4",
"react-native-ama": "0.6.20",
"react-native-ama": "0.7.5",
"react-native-gesture-handler": "~2.14.0",
"react-native-reanimated": "~3.6.2",
"react-native-safe-area-context": "4.8.2",
Expand Down
6 changes: 1 addition & 5 deletions src/components/buttons/button-icon/button-icon.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { Pressable } from 'react-native';
import { Pressable } from 'react-native-ama';

import { ButtonIconProps } from './button-icon.types';
import {
Expand All @@ -13,10 +13,6 @@ import { Icon } from '../../../primitives/icon/icon';
import { Skeleton } from '../../../primitives/skeleton/skeleton';
import Spinner from '../../spinner/spinner';

/**
* Todo - Use pressable from react-native-ama when issue below fixed
* https://github.com/FormidableLabs/react-native-ama/issues/92
*/
export const ButtonIcon = ({
accessibilityLabel,
iconName,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { Pressable } from 'react-native';
import { Pressable } from 'react-native-ama';

import { BottomContent } from './components/bottom-content';
import { CenterContent } from './components/center-content';
Expand All @@ -18,10 +18,6 @@ import {

const DIVIDER_VERTICAL_MARGIN = 16;

/**
* Todo - Use pressable from react-native-ama when issue below fixed
* https://github.com/FormidableLabs/react-native-ama/issues/92
*/
export const ListItemValue = ({
appearance = 'neutral',
accessibilityLabel,
Expand Down
6 changes: 1 addition & 5 deletions src/components/list-items/list-item/list-item.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { Pressable } from 'react-native';
import { Pressable } from 'react-native-ama';

import { CenterContent } from './components/center-content';
import { LeftContent } from './components/left-content';
Expand All @@ -17,10 +17,6 @@ import {

const DIVIDER_VERTICAL_MARGIN = 16;

/**
* Todo - Use pressable from react-native-ama when issue below fixed
* https://github.com/FormidableLabs/react-native-ama/issues/92
*/
export const ListItem = ({
appearance = 'neutral',
accessibilityLabel,
Expand Down
Loading

0 comments on commit 3695202

Please sign in to comment.