Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InputCode): use local state to avoid wrong code value #159

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

hcourthias
Copy link
Contributor

Summary

When typing on a simulator, the previous code wasn't working well. The state wasn't updated quick enough. To fix this I implemented a local state, so we can use the prev value. The onChange fn is then called inside a useEffect when code is updated

@hcourthias hcourthias requested a review from judastheo February 26, 2024 16:12
@hcourthias hcourthias self-assigned this Feb 26, 2024
Copy link

🚀 Expo preview is ready!

  • Project → sandbox
  • Platforms → android, ios
  • Runtime Version → exposdk:50.0.0
  • More info

Learn more about 𝝠 Expo Github Action

Copy link
Member

@judastheo judastheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@judastheo judastheo merged commit 17bd09d into dev Feb 27, 2024
4 checks passed
@judastheo judastheo deleted the hugo/fix/input-code branch February 27, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants