-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for arXiv entries and non-PDF URLs #97
Conversation
The title states Can you link to where Also, the PR is failing the checks and would need fixing before it can be merged. |
Hi @gcushen, thanks for taking a look. I looked at your comment only after noticing the build failure and pushing the fix for that. About "URL" vs the "PDF" label, I think currently the choice to apply the PDF label to any URL without validation that it points to a PDF is incorrect. See, for example, a large bibliography database that I maintain at http://ks.cs.uchicago.edu/qpl-bib/ which is generated using the tool About |
Yes, we should check if the URL ends in .pdf (case-insensitive) to maintain backward compatibility for users. Let's keep the labels user friendly though and not label links as tech protocols like HTTP and HTTPS. If arxiv.org are generating bibtex with non-standard |
Alright, I don't see the option to convert this into a draft PR, but I will try and make the changes and let you know when it's ready for a potential merge. I am not sure what is the clearly defined existing spec that you are referring to. arXiv is large enough that
|
Hi @gcushen, I have made the change as you suggested. This PR is now ready for merge. |
No description provided.