Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBE-3881] message list scrolls down on reaction #5280

Merged
merged 4 commits into from
Jun 13, 2024
Merged

[PBE-3881] message list scrolls down on reaction #5280

merged 4 commits into from
Jun 13, 2024

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Jun 12, 2024

🎯 Goal

Resolves:

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat requested a review from a team as a code owner June 12, 2024 21:10
@kanat kanat added bug Something isn't working v6 labels Jun 12, 2024
@JcMinarro JcMinarro enabled auto-merge (rebase) June 13, 2024 22:14
@JcMinarro JcMinarro merged commit 48fe310 into develop Jun 13, 2024
7 checks passed
@JcMinarro JcMinarro deleted the bugfix/message-list-scroll branch June 13, 2024 22:14
@JcMinarro JcMinarro mentioned this pull request Jul 2, 2024
Closed
@kanat kanat mentioned this pull request Oct 3, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees
No one assigned
Labels
bug Something isn't working v6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanat @JcMinarro