Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBE-4110] fix quoted message styling #5287

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Jun 14, 2024

🎯 Goal

Closes:

🛠 Implementation details

We should not apply styling depending on both quotedMessage.isMine and containerMessage.isMine combined.
It brings complexity in understanding and expectations on UI customizations

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat requested a review from a team as a code owner June 14, 2024 22:32
@aleksandar-apostolov aleksandar-apostolov merged commit 36403b0 into develop Jun 17, 2024
7 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the ui/quoted-message-styling branch June 17, 2024 08:05
@kanat kanat added bug Something isn't working ui-components v6 labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui-components v6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants