Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBE-5701] Expose top and bottom bar in MessageScreen #5377

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

aleksandar-apostolov
Copy link
Collaborator

🎯 Goal

Expose the bottom and top bar of the Scaffold inside the MessageScreen.

🛠 Implementation details

The Scaffold topBar contains the MessageListHeader and the bottomBar contains the MessageComposer instead of exposing the list header or the composer, we just expose the bottom bar and top bar so that custom composer can be done or custom top header etc..

🎨 UI Changes

N/A

🧪 Testing

Run the Compose sample and verify.

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • [ x] Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • [ x] PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • [ x] Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • [ x] Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

@aleksandar-apostolov aleksandar-apostolov requested a review from a team as a code owner August 27, 2024 13:39
aleksandar-apostolov and others added 4 commits August 28, 2024 09:33
…-remove-user-IDs-from-mention-list

# Conflicts:
#	CHANGELOG.md
…5381)

* [PBE-5701] extract DefaultTopBarContent and DefatulBottomBarContent

* [PBE-5701] spotless & api dump
@kanat kanat enabled auto-merge (squash) August 28, 2024 14:58
@kanat kanat merged commit 1dafc60 into develop Aug 28, 2024
7 checks passed
@kanat kanat deleted the PBE-5701-Option-to-remove-user-IDs-from-mention-list branch August 28, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants