-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PinnedMessageList Compose #5420
Merged
aleksandar-apostolov
merged 15 commits into
develop
from
feature/compose-pinned-messages
Oct 7, 2024
Merged
PinnedMessageList Compose #5420
aleksandar-apostolov
merged 15 commits into
develop
from
feature/compose-pinned-messages
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
# Conflicts: # stream-chat-android-compose-sample/src/main/java/io/getstream/chat/android/compose/sample/ui/MessagesActivity.kt
aleksandar-apostolov
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The goal of the PR is to introduce a compose implementation of the
PinnedMessageList
component (which already exists in the XML SDK)🛠 Implementation details
PinnedMessageListViewModel
into aPinnedMessageListController
.PinnedMessageListController
in the already existingPinnedMessageListViewModel
(xml
) and in the newPinnedMessageListViewModel
(compose
).PinnedMessageList
composable component which accepts thePinnedMessageListViewModel
.MessagePreviewItem
which serves as a base for thePinnedMessageItem
composable -> similar to how this is done in the XML (MessagePreviewView
used for: SearchResults, PinnedMessages and Mentions). In the future, we can use the same item to also handle the Mentions when we implement them in compose.MessagePreviewFormatter
interface with a new method:formatMessageTitle
- this formatter can now be used to format both the title and the body of theMessagePreviewItem
Additional: Implement basic
ChannelInfoActivity
,GroupChannelInfoActivity
andPinnedMessagesActivity
in the compose sample so that the 'pinned messages' composable can be easily tested. (used the XML sample as a UI reference)🎨 UI Changes
PinnedMessageList
showcase-empty-xml-4.mp4
showcase-empty-compose.mp4
showcase-error-xml.mp4
showcase-error-compose.mp4
showcase-pagination-xml.mp4
showcase-pagination-compose.mp4
Compose sample app
🧪 Testing
☑️Contributor Checklist
General
develop
branchCode & documentation
☑️Reviewer Checklist
🎉 GIF
Please provide a suitable gif that describes your work on this pull request